The purpose of this study was to understand how a group of pre-service English language teachers constructed and negotiated their identities as teachers during a teaching practicum. The results of this study suggest that the identity work is an essential feature of student teachers’ experiences of a teaching practicum as they attempt to position themselves as particular types of teachers, not only within their placement schools, but also in relation to their understandings of what it means to be a language teacher, both within Hong Kong and beyond. However, the study also highlighted the potential for identity conflict that can arise if there is a mismatch between the subject positions offered to pre-service teachers within teacher education programmes and practicum placement schools and the student teachers own self-positioning as teachers.